Re: Intermittent Failures in t1450-fsck (Bisected)

From: Brian Gernhardt <benji@silverinsanity.com>
Date: May 5, 2011, 06:46 UTC
Message-ID: <2838BCC7-FB14-401B-9498-D0FB78C98D91@silverinsanity.com>
In-Reply-To: <115C364B-E910-4A9C-949E-3B10E5E6116C@silverinsanity.com>

I finally managed to pin down what triggers the bug and bisect it to its beginning.

I see this failure only when the test suite is run in parallel.  (make -j or -j in GIT_PROVE_OPTS)

The bug starts happening in "e96c19c: config: support values longer than 1023 bytes".

I have no idea why this commit causes failures in a test for fsck, but commits before it were merged work and commits after do not.  (Its direct ancestors work as well.)  Even more telling, reverting it on top of next causes the test to pass again.

~~ Brian

On Apr 13, 2011, at 1:11 PM, Brian Gernhardt wrote:

Show 34 quoted lines

> t1450-fsck fails in test 10 "tag pointing to something else than its type", but only if I run it as part of the full test suite (with either `make test` or `make prove`).  If I run the test separately, it passes.
> 
> The output from running with GIT_TEST_OPTS="-v" is:
> 
> expecting success: 
> 	sha=$(echo blob | git hash-object -w --stdin) &&
> 	test_when_finished "remove_object $sha" &&
> 	cat >wrong-tag <<-EOF &&
> 	object $sha
> 	type commit
> 	tag wrong
> 	tagger T A Gger <tagger@example.com> 1234567890 -0000
> 
> 	This is an invalid tag.
> 	EOF
> 
> 	tag=$(git hash-object -t tag -w --stdin <wrong-tag) &&
> 	test_when_finished "remove_object $tag" &&
> 	echo $tag >.git/refs/tags/wrong &&
> 	test_when_finished "git update-ref -d refs/tags/wrong" &&
> 	test_must_fail git fsck --tags 2>out &&
> 	cat out &&
> 	grep "error in tag.*broken links" out
> 
> tagged commit 63499e4ea8e096b831515ceb1d5a7593e4d87ae5 (wrong) in 66f6581d549f70e05ca586bc2df5c15a95662c36
> missing commit 63499e4ea8e096b831515ceb1d5a7593e4d87ae5
> error: Object 63499e4ea8e096b831515ceb1d5a7593e4d87ae5 is a commit, not a blob
> error: 63499e4ea8e096b831515ceb1d5a7593e4d87ae5: object corrupt or missing
> not ok - 10 tag pointing to something else than its type
> 
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html