Re: Intermittent Failures in t1450-fsck (Bisected)

From: Brian Gernhardt <benji@silverinsanity.com>
Date: May 5, 2011, 21:07 UTC
Message-ID: <1A288BE9-F001-4CAD-8A89-4B4D6F0F246B@silverinsanity.com>
In-Reply-To: <60194977-A4A9-4E18-9878-C1CDE77B75C2@silverinsanity.com>

On May 5, 2011, at 4:04 PM, Brian Gernhardt wrote:

Show 6 quoted lines

> On May 5, 2011, at 5:32 AM, Jeff King wrote:
> 
>> Given that the problem seems racy and intermittent, have you tried
>> running under valgrind?
> 
> This is on my OS X laptop and last I knew valgrind was very buggy on OS X, so I've never tried it.  I'll install it now and see if I can get anything useful out of it.

I will note the test _reliably_ fails when run in parallel with other tests.

Under valgrind I get the following error.  I will note that attempting to run the full test suite with valgrind gives lots of similar errors in many tests.  (All conditional jump in deflate, allocated in write_loose_object.)

==14187== Conditional jump or move depends on uninitialised value(s)
==14187==    at 0x100209B3B: deflateEnd (in /usr/lib/libz.1.2.3.dylib)
==14187==    by 0x10020ABF6: deflateSetDictionary (in /usr/lib/libz.1.2.3.dylib)
==14187==    by 0x10020B914: deflate (in /usr/lib/libz.1.2.3.dylib)
==14187==    by 0x1000FA631: write_loose_object (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==    by 0x1000FA8C8: write_sha1_file (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==    by 0x1000FACFB: index_mem (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==    by 0x1000FAE95: index_fd (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==    by 0x100038258: hash_fd (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==    by 0x1000386AA: cmd_hash_object (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==    by 0x1000016BC: run_builtin (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==    by 0x10000186E: handle_internal_command (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==    by 0x10000195F: run_argv (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==  Uninitialised value was created by a heap allocation
==14187==    at 0x1001F5345: malloc (vg_replace_malloc.c:236)
==14187==    by 0x10020A0FB: deflateInit2_ (in /usr/lib/libz.1.2.3.dylib)
==14187==    by 0x10020A264: deflateInit_ (in /usr/lib/libz.1.2.3.dylib)
==14187==    by 0x1000FA588: write_loose_object (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==    by 0x1000FA8C8: write_sha1_file (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==    by 0x1000FACFB: index_mem (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==    by 0x1000FAE95: index_fd (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==    by 0x100038258: hash_fd (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==    by 0x1000386AA: cmd_hash_object (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==    by 0x1000016BC: run_builtin (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==    by 0x10000186E: handle_internal_command (in /Users/brian/dev/git/t/valgrind/../../git)
==14187==    by 0x10000195F: run_argv (in /Users/brian/dev/git/t/valgrind/../../git)
==14187== 
{
   <insert_a_suppression_name_here>
   Memcheck:Cond
   fun:deflateEnd
   fun:deflateSetDictionary
   fun:deflate
   fun:write_loose_object
   fun:write_sha1_file
   fun:index_mem
   fun:index_fd
   fun:hash_fd
   fun:cmd_hash_object
   fun:run_builtin
   fun:handle_internal_command
   fun:run_argv
}