Re: Intermittent Failures in t1450-fsck (Bisected)

From: Jeff King <peff@peff.net>
Date: May 5, 2011, 21:03 UTC
Message-ID: <20110505210317.GE1770@sigill.intra.peff.net>
In-Reply-To: <60194977-A4A9-4E18-9878-C1CDE77B75C2@silverinsanity.com>

On Thu, May 05, 2011 at 04:04:33PM -0400, Brian Gernhardt wrote:

> The original e-mail was from next at that point.  The output from the
> rebased version and current next (76e37e2) is identical.

Thanks. The weird thing is that running t1450 on 76e37e2 gives me this output:

broken link from tag 66f6581d549f70e05ca586bc2df5c15a95662c36 broken link from unknown unknown dangling blob 63499e4ea8e096b831515ceb1d5a7593e4d87ae5 error: Object 63499e4ea8e096b831515ceb1d5a7593e4d87ae5 is a blob, not a commit error in tag 66f6581d549f70e05ca586bc2df5c15a95662c36: broken links error in tag 66f6581d549f70e05ca586bc2df5c15a95662c36: could not load tagged object error in tag 66f6581d549f70e05ca586bc2df5c15a95662c36: broken links

whereas from your original email, you had:

> >>> tagged commit 63499e4ea8e096b831515ceb1d5a7593e4d87ae5 (wrong) in 66f6581d549f70e05ca586bc2df5c15a95662c36
> >>> missing commit 63499e4ea8e096b831515ceb1d5a7593e4d87ae5
> >>> error: Object 63499e4ea8e096b831515ceb1d5a7593e4d87ae5 is a commit, not a blob
> >>> error: 63499e4ea8e096b831515ceb1d5a7593e4d87ae5: object corrupt or missing

which is weird. We do call "remove_object $sha", but only inside test_when_finished. I wonder if there is some bug with test_when_finished on your platform. Have you tried instrumenting the remove_object function to print a message when it is run? That might give us a clue if it is accidentally being run early.

> This is on my OS X laptop and last I knew valgrind was very buggy on
> OS X, so I've never tried it.  I'll install it now and see if I can
> get anything useful out of it.

I've tried but been unable to reproduce on Linux, so it seems like something OS X specific.

-Peff