git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Intermittent Failures in t1450-fsck (Bisected)

From
Jeff King <peff@peff.net>
Date
May 5, 2011, 21:17 UTC
Message-ID
<20110505211736.GA7256@sigill.intra.peff.net>
In-Reply-To
<1A288BE9-F001-4CAD-8A89-4B4D6F0F246B@silverinsanity.com>
On Thu, May 05, 2011 at 05:07:54PM -0400, Brian Gernhardt wrote:
Show 10 quoted lines
> On May 5, 2011, at 4:04 PM, Brian Gernhardt wrote:
> 
> > On May 5, 2011, at 5:32 AM, Jeff King wrote:
> > 
> >> Given that the problem seems racy and intermittent, have you tried
> >> running under valgrind?
> > 
> > This is on my OS X laptop and last I knew valgrind was very buggy on OS X, so I've never tried it.  I'll install it now and see if I can get anything useful out of it.
> 
> I will note the test _reliably_ fails when run in parallel with other tests.

It might be interference from another test, though in general they should all be in their own little sandboxes. It could just be a race condition that gets triggered more reliably when the system is under load.

> Under valgrind I get the following error.  I will note that attempting
> to run the full test suite with valgrind gives lots of similar errors
> in many tests.  (All conditional jump in deflate, allocated in
> write_loose_object.)

This is probably a false positive. On Linux we see these in libz because it has some weird optimized loop that can read past the end of the buffer (though I have usually see it in the inflate code path, not deflate).

-Peff
Previous: Brian Gernhardt
Message 10 of 10 in “Intermittent Failures in t1450-fsck”
  1. Brian GernhardtApr 13, 2011
  2. Brian GernhardtMay 5, 2011
  3. Jeff KingMay 5, 2011
  4. Brian GernhardtMay 5, 2011
  5. Jeff KingMay 5, 2011
  6. Brian GernhardtMay 5, 2011
  7. Brian GernhardtMay 7, 2011
  8. Jeff KingMay 11, 2011
  9. Brian GernhardtMay 5, 2011
  10. Jeff KingMay 5, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.