git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (May 2024, #04; Thu, 9)

From
Justin Tobler <jltobler@gmail.com>
Date
May 10, 2024, 18:39 UTC
Message-ID
<262znkm7vg77nzp5fadhfuqkcs6wapsuzd5dtvffoopszzoyia@uohyfeerbncl>
In-Reply-To
<Zj5I9J-l24Pk-10q@framework>
On 24/05/10 06:19PM, Patrick Steinhardt wrote:
> On Fri, May 10, 2024 at 08:35:16AM -0700, Junio C Hamano wrote:
Show 18 quoted lines
> > "I read it and have no comments" is somewhere between "an invitation
> > to miss" and "it does not highlight anything, either positive or
> > negative.  Was the topic that uninteresting and uninspiring without
> > anything noteworthy?".
> 
> I figured that this might've been it.
> 
> > There were mentions of a new document for reviewers, similar to
> > SubmittingPatches is for contributors, and it would make a good
> > section to document recommended ways for reviewers to demonstrate
> > that they understand (1) the area, (2) the goal of the patches, and
> > (3) the implementation presented, better.
> 
> Right, that's good feedback indeed. Ask questions, reexplain what
> happens with your own words to both double check your understanding and
> demonstrate it to others, ask for alternative ways to implement
> something. These are all ways to ACK a patch series that otherwise looks
> good to you already.
Noted. Thanks both for the feedback! :)
-Justin
Previous: Patrick Steinhardt
Message 7 of 7 in “What's cooking in git.git (May 2024, #04; Thu, 9)”
  1. Junio C HamanoMay 9, 2024
  2. Junio C HamanoMay 10, 2024
  3. Torsten BögershausenMay 10, 2024
  4. Patrick SteinhardtMay 10, 2024
  5. Junio C HamanoMay 10, 2024
  6. Patrick SteinhardtMay 10, 2024
  7. Justin ToblerMay 10, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.