Re: What's cooking in git.git (May 2024, #04; Thu, 9)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 10, 2024, 15:35 UTC
- Message-ID
- <xmqq5xvl7k97.fsf@gitster.g>
- In-Reply-To
- <Zj3SsbHLp-gH_Jey@tanuki>
Patrick Steinhardt <ps@pks.im> writes:
> Just in case you missed it, there was a review by Justin already [1].
"I read it and have no comments" is somewhere between "an invitation to miss" and "it does not highlight anything, either positive or negative. Was the topic that uninteresting and uninspiring without anything noteworthy?".
There were mentions of a new document for reviewers, similar to SubmittingPatches is for contributors, and it would make a good section to document recommended ways for reviewers to demonstrate that they understand (1) the area, (2) the goal of the patches, and (3) the implementation presented, better.