From: Justin Tobler <jltobler@gmail.com>
Date: Fri, 10 May 2024 18:39:17 GMT
Subject: Re: What's cooking in git.git (May 2024, #04; Thu, 9)
Message-ID: <262znkm7vg77nzp5fadhfuqkcs6wapsuzd5dtvffoopszzoyia@uohyfeerbncl>
In-Reply-To: <Zj5I9J-l24Pk-10q@framework>

On 24/05/10 06:19PM, Patrick Steinhardt wrote:
> On Fri, May 10, 2024 at 08:35:16AM -0700, Junio C Hamano wrote:

> > "I read it and have no comments" is somewhere between "an invitation
> > to miss" and "it does not highlight anything, either positive or
> > negative.  Was the topic that uninteresting and uninspiring without
> > anything noteworthy?".
> 
> I figured that this might've been it.
> 
> > There were mentions of a new document for reviewers, similar to
> > SubmittingPatches is for contributors, and it would make a good
> > section to document recommended ways for reviewers to demonstrate
> > that they understand (1) the area, (2) the goal of the patches, and
> > (3) the implementation presented, better.
> 
> Right, that's good feedback indeed. Ask questions, reexplain what
> happens with your own words to both double check your understanding and
> demonstrate it to others, ask for alternative ways to implement
> something. These are all ways to ACK a patch series that otherwise looks
> good to you already.

Noted. Thanks both for the feedback! :)

-Justin