Re: What's cooking in git.git (May 2024, #04; Thu, 9)

From: Junio C Hamano <gitster@pobox.com>
Date: May 10, 2024, 01:04 UTC
Message-ID: <xmqq5xvmschw.fsf@gitster.g>
In-Reply-To: <xmqqfruqsjb6.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 10 quoted lines

> * cw/git-std-lib (2024-02-28) 4 commits
>  - SQUASH??? get rid of apparent debugging crufts
>  - test-stdlib: show that git-std-lib is independent
>  - git-std-lib: introduce Git Standard Library
>  - pager: include stdint.h because uintmax_t is used
>
>  Split libgit.a out to a separate git-std-lib tor easier reuse.
>
>  Expecting a reroll.
>  source: <cover.1696021277.git.jonathantanmy@google.com>

Just a heads-up. The topic is pushed out of 'seen', as it seems to be hated by osx-* jobs when linking programs. As the topic has been expecting a reroll for some time, it is not ultra urgent to fix this, but before resurrecting it, we may want to look into it.

https://github.com/git/git/actions/runs/9023837489

is an example run where we see error messages like:

ld: warning: ignoring duplicate libraries: 'git-std-lib.a', 'libgit.a', 'reftable/libreftable.a', 'xdiff/lib.a'

and

ld: Undefined symbols:
    _git_config_get_bool, referenced from:
        _precompose_string_if_needed in git-std-lib.a[11](precompose_utf8.o)

in both clang and gcc jobs.

We did not see these breakages before, and we do not see these breakages in today's 'seen' with this topic excluded. I haven't tried to include this but excluding tb/precompose-getcwd topic instead, which I suspect might also work.

Thanks.