git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] hook tests: fix redirection logic error in 96e7225b310

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Oct 31, 2022, 12:44 UTC
Message-ID
<221031.86tu3k6u2d.gmgdl@evledraar.gmail.com>
In-Reply-To
<Y12I7zSohPu2cyJt@nand.local>
On Sat, Oct 29 2022, Taylor Blau wrote:
Show 16 quoted lines
> [+cc Emily]
>
> On Sat, Oct 29, 2022 at 04:59:45AM +0200, Ævar Arnfjörð Bjarmason wrote:
>> diff --git a/t/t1800-hook.sh b/t/t1800-hook.sh
>> index 43fcb7c0bfc..2ef3579fa7c 100755
>> --- a/t/t1800-hook.sh
>> +++ b/t/t1800-hook.sh
>> @@ -95,7 +95,7 @@ test_expect_success 'git hook run -- out-of-repo runs excluded' '
>>  test_expect_success 'git -c core.hooksPath=<PATH> hook run' '
>>  	mkdir my-hooks &&
>>  	write_script my-hooks/test-hook <<-\EOF &&
>> -	echo Hook ran $1 >>actual
>> +	echo Hook ran $1
>>  	EOF
>
> Looking reasonable to me. Though let's see what Emily thinks, too...

FWIW Junio looked at it back in https://lore.kernel.org/git/xmqqczh84fpy.fsf@gitster.g/

Previous: Taylor BlauNext: Taylor Blau
Message 4 of 11 in “tests: improve misc run-command, hook, submodule tests”
  1. 0/3 tests: improve misc run-command, hook, submodule testsÆvar Arnfjörð Bjarmason, Oct 29, 2022
  2. 1/3 hook tests: fix redirection logic error in 96e7225b310Ævar Arnfjörð Bjarmason, Oct 29, 2022
  3. Taylor BlauOct 29, 2022
  4. Ævar Arnfjörð BjarmasonOct 31, 2022
  5. Taylor BlauOct 31, 2022
  6. 2/3 submodule tests: reset "trace.out" between "grep" invocationsÆvar Arnfjörð Bjarmason, Oct 29, 2022
  7. Taylor BlauOct 29, 2022
  8. Ævar Arnfjörð BjarmasonOct 31, 2022
  9. Taylor BlauOct 31, 2022
  10. 3/3 run-command tests: test stdout of run_command_parallel()Ævar Arnfjörð Bjarmason, Oct 29, 2022
  11. Taylor BlauOct 29, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.