From: Ævar Arnfjörð Bjarmason Date: Mon, 31 Oct 2022 12:44:44 GMT Subject: Re: [PATCH 1/3] hook tests: fix redirection logic error in 96e7225b310 Message-ID: <221031.86tu3k6u2d.gmgdl@evledraar.gmail.com> In-Reply-To: On Sat, Oct 29 2022, Taylor Blau wrote: > [+cc Emily] > > On Sat, Oct 29, 2022 at 04:59:45AM +0200, Ævar Arnfjörð Bjarmason wrote: >> diff --git a/t/t1800-hook.sh b/t/t1800-hook.sh >> index 43fcb7c0bfc..2ef3579fa7c 100755 >> --- a/t/t1800-hook.sh >> +++ b/t/t1800-hook.sh >> @@ -95,7 +95,7 @@ test_expect_success 'git hook run -- out-of-repo runs excluded' ' >> test_expect_success 'git -c core.hooksPath= hook run' ' >> mkdir my-hooks && >> write_script my-hooks/test-hook <<-\EOF && >> - echo Hook ran $1 >>actual >> + echo Hook ran $1 >> EOF > > Looking reasonable to me. Though let's see what Emily thinks, too... FWIW Junio looked at it back in https://lore.kernel.org/git/xmqqczh84fpy.fsf@gitster.g/