Re: [PATCH 1/3] hook tests: fix redirection logic error in 96e7225b310

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 31, 2022, 23:56 UTC
Message-ID: <Y2BgwZ45C+Oqs+W0@nand.local>
In-Reply-To: <221031.86tu3k6u2d.gmgdl@evledraar.gmail.com>

On Mon, Oct 31, 2022 at 01:44:44PM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 22 quoted lines

>
> On Sat, Oct 29 2022, Taylor Blau wrote:
>
> > [+cc Emily]
> >
> > On Sat, Oct 29, 2022 at 04:59:45AM +0200, Ævar Arnfjörð Bjarmason wrote:
> >> diff --git a/t/t1800-hook.sh b/t/t1800-hook.sh
> >> index 43fcb7c0bfc..2ef3579fa7c 100755
> >> --- a/t/t1800-hook.sh
> >> +++ b/t/t1800-hook.sh
> >> @@ -95,7 +95,7 @@ test_expect_success 'git hook run -- out-of-repo runs excluded' '
> >>  test_expect_success 'git -c core.hooksPath=<PATH> hook run' '
> >>  	mkdir my-hooks &&
> >>  	write_script my-hooks/test-hook <<-\EOF &&
> >> -	echo Hook ran $1 >>actual
> >> +	echo Hook ran $1
> >>  	EOF
> >
> > Looking reasonable to me. Though let's see what Emily thinks, too...
>
> FWIW Junio looked at it back in
> https://lore.kernel.org/git/xmqqczh84fpy.fsf@gitster.g/

Good, though I would like some feedback from Emily, too, seeing as most of this code blames back to her.

Thanks, Taylor