git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] hook tests: fix redirection logic error in 96e7225b310

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Oct 29, 2022, 02:59 UTC
Message-ID
<patch-1.3-1ba41a5842c-20221029T025520Z-avarab@gmail.com>
In-Reply-To
<cover-0.3-00000000000-20221029T025520Z-avarab@gmail.com>

The tests added in 96e7225b310 (hook: add 'run' subcommand, 2021-12-22) were redirecting to "actual" both in the body of the hook itself and in the testing code below.

The net result was that the "2>>actual" redirection later in the test wasn't doing anything. Let's have those redirection do what it looks like they're doing.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 t/t1800-hook.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t1800-hook.sh b/t/t1800-hook.sh
index 43fcb7c0bfc..2ef3579fa7c 100755
--- a/t/t1800-hook.sh
+++ b/t/t1800-hook.sh
@@ -95,7 +95,7 @@ test_expect_success 'git hook run -- out-of-repo runs excluded' '
 test_expect_success 'git -c core.hooksPath=<PATH> hook run' '
 	mkdir my-hooks &&
 	write_script my-hooks/test-hook <<-\EOF &&
-	echo Hook ran $1 >>actual
+	echo Hook ran $1
 	EOF
 
 	cat >expect <<-\EOF &&
-- 
2.38.0.1280.g8136eb6fab2
Previous: Ævar Arnfjörð BjarmasonNext: Taylor Blau
Message 2 of 11 in “tests: improve misc run-command, hook, submodule tests”
  1. 0/3 tests: improve misc run-command, hook, submodule testsÆvar Arnfjörð Bjarmason, Oct 29, 2022
  2. 1/3 hook tests: fix redirection logic error in 96e7225b310Ævar Arnfjörð Bjarmason, Oct 29, 2022
  3. Taylor BlauOct 29, 2022
  4. Ævar Arnfjörð BjarmasonOct 31, 2022
  5. Taylor BlauOct 31, 2022
  6. 2/3 submodule tests: reset "trace.out" between "grep" invocationsÆvar Arnfjörð Bjarmason, Oct 29, 2022
  7. Taylor BlauOct 29, 2022
  8. Ævar Arnfjörð BjarmasonOct 31, 2022
  9. Taylor BlauOct 31, 2022
  10. 3/3 run-command tests: test stdout of run_command_parallel()Ævar Arnfjörð Bjarmason, Oct 29, 2022
  11. Taylor BlauOct 29, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.