From: Junio C Hamano Date: Fri, 30 Oct 2026 17:39:53 GMT Subject: [PATCH 1/4] ident: remove unused author_ident_sufficiently_given() Message-ID: <20261030173956.585250-2-gitster@pobox.com> In-Reply-To: <20261030173956.585250-1-gitster@pobox.com> A pair of functions {author,committer}_ident_sufficiently_given() were created to replace user_ident_explicitly_given() in d6991ceedc (ident: keep separate "explicit" flags for author and committer, 2012-11-14). But author_ident_sufficiently_given() is never used in our history. We only check if committer ident is sufficiently given and use it to nudge the user to set user.{name,email} configuration variables. Remove the unused author_ident_sufficiently_given() function. Signed-off-by: Junio C Hamano --- ident.c | 5 ----- ident.h | 1 - 2 files changed, 6 deletions(-) diff --git a/ident.c b/ident.c index 0b7aacecd7..eb73d073d8 100644 --- a/ident.c +++ b/ident.c @@ -602,11 +602,6 @@ int committer_ident_sufficiently_given(void) return ident_is_sufficient(committer_ident_explicitly_given); } -int author_ident_sufficiently_given(void) -{ - return ident_is_sufficient(author_ident_explicitly_given); -} - static int set_ident(const char *var, const char *value) { if (!strcmp(var, "author.name")) { diff --git a/ident.h b/ident.h index 3c03403879..7e60e36415 100644 --- a/ident.h +++ b/ident.h @@ -60,7 +60,6 @@ const char *fmt_ident(const char *name, const char *email, const char *fmt_name(enum want_ident); int committer_ident_sufficiently_given(void); -int author_ident_sufficiently_given(void); struct config_context; int git_ident_config(const char *, const char *, const struct config_context *, -- 2.56.0-486-gd49ba3b80a