git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pack-bitmap: handle objects at bitmap position zero

From
DLDavid Lin <davidzylin@gmail.com>
Date
Jul 28, 2026, 13:40 UTC
Message-ID
<20260728134047.33801-1-davidlin@stripe.com>
In-Reply-To
<ame6B7pHSvXekdPZ@com-79390>
On Mon, Jul 27, 2026 at 03:05:27PM -0500, Taylor Blau wrote:
> Makes sense. The commit message here and below looks reasonable, but
> please wrap it at a maximum of 72 characters per line.
Done in v2, apologize for the formatting.
> At this point, "load" is a fairly cheap operation. We have already
> loaded the bits off of disk in a previous step. If the bitmap was
> stored as an XOR against a neighbor, we have already XOR'd it against
> that neighbor and stored the result.

Agree, I reworded the commit message/comment to consolidate the wording, so that a duplicate disk read is not always implied.

> However, I think it's worth covering the non-pseudo-merge case as I
> described above, too.

Good call, and thank you for the expanded explanation above, added in v2 using a duplicate `HEAD` traversal, as suggested.

Thanks again for the detailed review. I will send v2 shortly.

Best, David

Previous: Taylor BlauNext: David Lin
Message 3 of 6 in “pack-bitmap: handle objects at bitmap position zero”
  1. pack-bitmap: handle objects at bitmap position zeroDavid Lin, Jul 27, 2026
  2. Taylor BlauJul 27, 2026
  3. David LinJul 28, 2026
  4. pack-bitmap: handle objects at bitmap position zeroDavid Lin, Jul 28, 2026
  5. Junio C HamanoJul 28, 2026
  6. Taylor BlauJul 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.