Re: [PATCH v2] pack-bitmap: handle objects at bitmap position zero
David Lin <davidzylin@gmail.com> writes:
Show 13 quoted lines
> `bitmap_position()` only returns a negative value when an object is not
> present in the bitmap index.
> ...
> Also cover the non-pseudo-merge case by passing `HEAD` twice. The first
> occurrence initializes the base from its stored bitmap, and the second
> must recognize that position zero is already present.
>
> Helped-by: Taylor Blau <ttaylorr@openai.com>
> Signed-off-by: David Lin <davidlin@stripe.com>
> ---
> Changes since v1:
> - Clarify the bitmap disk load wordings.
> - Add coverage for the non-pseudo-merge case.
Thanks, both of you. Will queue.