git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] pack-bitmap: handle objects at bitmap position zero

From
Taylor Blau <ttaylorr@openai.com>
Date
Jul 28, 2026, 23:31 UTC
Message-ID
<amk75SuhyHBbx-E8@com-79390>
In-Reply-To
<xmqq5x1yd968.fsf@gitster.g>
On Tue, Jul 28, 2026 at 03:46:39PM -0700, Junio C Hamano wrote:
Show 17 quoted lines
> David Lin <davidzylin@gmail.com> writes:
>
> > `bitmap_position()` only returns a negative value when an object is not
> > present in the bitmap index.
> > ...
> > Also cover the non-pseudo-merge case by passing `HEAD` twice. The first
> > occurrence initializes the base from its stored bitmap, and the second
> > must recognize that position zero is already present.
> >
> > Helped-by: Taylor Blau <ttaylorr@openai.com>
> > Signed-off-by: David Lin <davidlin@stripe.com>
> > ---
> > Changes since v1:
> > - Clarify the bitmap disk load wordings.
> > - Add coverage for the non-pseudo-merge case.
>
> Thanks, both of you.  Will queue.
This version looks good to me.

Thanks, Taylor

Previous: Junio C Hamano
Message 6 of 6 in “pack-bitmap: handle objects at bitmap position zero”
  1. pack-bitmap: handle objects at bitmap position zeroDavid Lin, Jul 27, 2026
  2. Taylor BlauJul 27, 2026
  3. David LinJul 28, 2026
  4. pack-bitmap: handle objects at bitmap position zeroDavid Lin, Jul 28, 2026
  5. Junio C HamanoJul 28, 2026
  6. Taylor BlauJul 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.