Re: [PATCH v2] pack-bitmap: handle objects at bitmap position zero
- From
Taylor Blau <ttaylorr@openai.com>
- Date
- Jul 28, 2026, 23:31 UTC
- Message-ID
- <amk75SuhyHBbx-E8@com-79390>
- In-Reply-To
- <xmqq5x1yd968.fsf@gitster.g>
On Tue, Jul 28, 2026 at 03:46:39PM -0700, Junio C Hamano wrote:
Show 17 quoted lines
> David Lin <davidzylin@gmail.com> writes: > > > `bitmap_position()` only returns a negative value when an object is not > > present in the bitmap index. > > ... > > Also cover the non-pseudo-merge case by passing `HEAD` twice. The first > > occurrence initializes the base from its stored bitmap, and the second > > must recognize that position zero is already present. > > > > Helped-by: Taylor Blau <ttaylorr@openai.com> > > Signed-off-by: David Lin <davidlin@stripe.com> > > --- > > Changes since v1: > > - Clarify the bitmap disk load wordings. > > - Add coverage for the non-pseudo-merge case. > > Thanks, both of you. Will queue.
This version looks good to me.
Thanks, Taylor