From: David Lin Date: Tue, 28 Jul 2026 13:40:47 GMT Subject: Re: [PATCH] pack-bitmap: handle objects at bitmap position zero Message-ID: <20260728134047.33801-1-davidlin@stripe.com> In-Reply-To: On Mon, Jul 27, 2026 at 03:05:27PM -0500, Taylor Blau wrote: > Makes sense. The commit message here and below looks reasonable, but > please wrap it at a maximum of 72 characters per line. Done in v2, apologize for the formatting. > At this point, "load" is a fairly cheap operation. We have already > loaded the bits off of disk in a previous step. If the bitmap was > stored as an XOR against a neighbor, we have already XOR'd it against > that neighbor and stored the result. Agree, I reworded the commit message/comment to consolidate the wording, so that a duplicate disk read is not always implied. > However, I think it's worth covering the non-pseudo-merge case as I > described above, too. Good call, and thank you for the expanded explanation above, added in v2 using a duplicate `HEAD` traversal, as suggested. Thanks again for the detailed review. I will send v2 shortly. Best, David