git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[GSoC PATCH v4] t9200: replace test -f with modern path helper

From
Pablo Sabater <pabloosabaterr@gmail.com>
Date
Mar 12, 2026, 17:33 UTC
Message-ID
<20260312173305.15112-1-pabloosabaterr@gmail.com>
In-Reply-To
<20260309150935.578465-1-pabloosabaterr@gmail.com>

Replace old style 'test -f' with helper 'test_path_is_file', which make debugging a failing test easier by loudly reporting what expectation was not met.

Signed-off-by: Pablo Sabater <pabloosabaterr@gmail.com>
---
Changes from v3:
The first hunk was dropped from this patch, and sent as a separate patch.
https://lore.kernel.org/git/20260311194002.190195-1-pabloosabaterr@gmail.com/
 t/t9200-git-cvsexportcommit.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh
index a44eabf0d8..15a91931a2 100755
--- a/t/t9200-git-cvsexportcommit.sh
+++ b/t/t9200-git-cvsexportcommit.sh
@@ -303,7 +303,7 @@ test_expect_success 're-commit a removed filename which remains in CVS attic' '
 	git commit -m "Added attic_gremlin" &&
 	git cvsexportcommit -w "$CVSWORK" -c HEAD &&
 	(cd "$CVSWORK" && cvs -Q update -d) &&
-	test -f "$CVSWORK/attic_gremlin"
+	test_path_is_file "$CVSWORK/attic_gremlin"
 '
 
 # the state of the CVS sandbox may be indeterminate for ' space'
-- 
2.43.0
Previous: Junio C HamanoNext: Junio C Hamano
Message 15 of 16 in “t9200: use helpers to replace test -f <path> and test -d <path>”
  1. t9200: use helpers to replace test -f <path> and test -d <path>Pablo Sabater, Mar 9, 2026
  2. Junio C HamanoMar 9, 2026
  3. PabloMar 9, 2026
  4. t9200: replace test -f/-d with modern path helpersPablo Sabater, Mar 9, 2026
  5. Junio C HamanoMar 9, 2026
  6. PabloMar 9, 2026
  7. t9200: replace test -f/-d with modern path helpersPablo Sabater, Mar 9, 2026
  8. Junio C HamanoMar 9, 2026
  9. PabloMar 11, 2026
  10. Junio C HamanoMar 11, 2026
  11. PabloMar 11, 2026
  12. Junio C HamanoMar 11, 2026
  13. PabloMar 11, 2026
  14. Junio C HamanoMar 11, 2026
  15. t9200: replace test -f with modern path helperPablo Sabater, Mar 12, 2026
  16. Junio C HamanoMar 12, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.