From: Pablo Sabater Date: Thu, 12 Mar 2026 17:33:05 GMT Subject: [GSoC PATCH v4] t9200: replace test -f with modern path helper Message-ID: <20260312173305.15112-1-pabloosabaterr@gmail.com> In-Reply-To: <20260309150935.578465-1-pabloosabaterr@gmail.com> Replace old style 'test -f' with helper 'test_path_is_file', which make debugging a failing test easier by loudly reporting what expectation was not met. Signed-off-by: Pablo Sabater --- Changes from v3: The first hunk was dropped from this patch, and sent as a separate patch. https://lore.kernel.org/git/20260311194002.190195-1-pabloosabaterr@gmail.com/ t/t9200-git-cvsexportcommit.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh index a44eabf0d8..15a91931a2 100755 --- a/t/t9200-git-cvsexportcommit.sh +++ b/t/t9200-git-cvsexportcommit.sh @@ -303,7 +303,7 @@ test_expect_success 're-commit a removed filename which remains in CVS attic' ' git commit -m "Added attic_gremlin" && git cvsexportcommit -w "$CVSWORK" -c HEAD && (cd "$CVSWORK" && cvs -Q update -d) && - test -f "$CVSWORK/attic_gremlin" + test_path_is_file "$CVSWORK/attic_gremlin" ' # the state of the CVS sandbox may be indeterminate for ' space' -- 2.43.0