Re: [GSoC PATCH v3] t9200: replace test -f/-d with modern path helpers

From: Pablo <pabloosabaterr@gmail.com>
Date: Mar 11, 2026, 19:49 UTC
Message-ID: <CAN5EUNSmZmdnDzpAKAh8fZRex3--tnKaWZZSQ+o5WATc6sLy_Q@mail.gmail.com>
In-Reply-To: <xmqqbjgunofq.fsf@gitster.g>

Show 5 quoted lines

> Yeah, but if we are going to do so eventually, it would be pointless
> to use the path helper in that "set up CVS environment and make sure
> we got a sensible directory structure" check, no?  Upon failure, we
> will hit test_done that loudly says that their CVS installation is
> not working as we expect.

Yeah, the new patch will change it back to test -d because it ends up in a if condition instead of an assertion. Would you prefer to drop that hunk from my v3 or should I send a v4 ?