[GSoC PATCH] t9200: use helpers to replace test -f <path> and test -d <path>
- From
Pablo Sabater <pabloosabaterr@gmail.com>
- Date
- Mar 9, 2026, 15:09 UTC
- Message-ID
- <20260309150935.578465-1-pabloosabaterr@gmail.com>
Replaced 'test -f' and 'test -d' with 'test_path_is_file' and 'test_path_is_dir'
I've used 'git grep "test -f" t/t9*.sh' to find a file without the fix done as specified on the microproject information I've done '9*' because the ones I've found first had already fix patches. I've taken as example another patch sent 't4131' from Junio C Hamano https://lore.kernel.org/git/xmqq1rpodn25.fsf@gitster.c.googlers.com/#r
Signed-off-by: Pablo Sabater <pabloosabaterr@gmail.com> --- t/t9200-git-cvsexportcommit.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh index a44eabf0d8..4507e8e6db 100755 --- a/t/t9200-git-cvsexportcommit.sh +++ b/t/t9200-git-cvsexportcommit.sh @@ -31,7 +31,7 @@ export CVSROOT CVSWORK GIT_DIR rm -rf "$CVSROOT" "$CVSWORK" cvs init && -test -d "$CVSROOT" && +test_path_is_dir "$CVSROOT" && cvs -Q co -d "$CVSWORK" . && echo >empty && git add empty && @@ -303,7 +303,7 @@ test_expect_success 're-commit a removed filename which remains in CVS attic' ' git commit -m "Added attic_gremlin" && git cvsexportcommit -w "$CVSWORK" -c HEAD && (cd "$CVSWORK" && cvs -Q update -d) && - test -f "$CVSWORK/attic_gremlin" + test_path_is_file "$CVSWORK/attic_gremlin" ' # the state of the CVS sandbox may be indeterminate for ' space'
-- 2.43.0