Re: [PATCH] diff: stop output garbled message in dry run mode

From: Jeff King <peff@peff.net>
Date: Oct 18, 2025, 09:47 UTC
Message-ID: <20251018094722.GC1060824@coredump.intra.peff.net>
In-Reply-To: <6C994C9C-0034-46D0-8112-FF88773B5CF5@gmail.com>

On Sat, Oct 18, 2025 at 09:11:34AM +0800, Lidong Yan wrote:

Show 6 quoted lines

> > Test that exercises "git diff -I<regex>" is in line with what the
> > original b55e6d36eb wanted to address, but given that we saw a
> > recent regression report like [*], I would have liked to see "git
> > diff --quiet" in the test as well.
> 
> I will read Peff’s test and see if I should also add some similar tests

What I was hoping was that we'd apply my patch, as a matter of release engineering (backing out the regression-causing bit of b55e6d36eb). And then you could make more-specific fixes on top (since -I would still have potential problems). And then you don't need to add a test for the regression case, since it's already there.

-Peff