Re: [PATCH] diff: stop output garbled message in dry run mode

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 18, 2025, 05:02 UTC
Message-ID: <xmqqo6q4x0o3.fsf@gitster.g>
In-Reply-To: <6C994C9C-0034-46D0-8112-FF88773B5CF5@gmail.com>

Lidong Yan <yldhome2d2@gmail.com> writes:

Show 10 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>> ...
>> Test that exercises "git diff -I<regex>" is in line with what the
>> original b55e6d36eb wanted to address, but given that we saw a
>> recent regression report like [*], I would have liked to see "git
>> diff --quiet" in the test as well.
>
> I will read Peff’s test and see if I should also add some similar tests
>
>> * https://lore.kernel.org/git/CACJRbWjwOQwJB13CwTfvhV3p+Hbn4KrNM9AtBanGtUS4V_1MbQ@mail.gmail.com/

Also I think the fprintf() in run_diff_cmd() Dscho noticed is a real problem. cf. <xmqqa51pz3ih.fsf@gitster.g>

Thanks for working on this.