git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] t5604: do not expect that HEAD is a valid tagname

From
Jeff King <peff@peff.net>
Date
Dec 2, 2024, 21:00 UTC
Message-ID
<20241202210006.GE776185@coredump.intra.peff.net>
In-Reply-To
<477f0dbd-60ed-4f73-b945-cdbdaf9f510a@app.fastmail.com>
On Mon, Dec 02, 2024 at 01:19:56PM +0100, Kristoffer Haugsbakk wrote:
Show 5 quoted lines
> On Mon, Dec 2, 2024, at 08:07, Junio C Hamano wrote:
> > 09116a1c (refs: loosen over-strict "format" check, 2011-11-16)
> 
> Nit/confusion: the abbreviated hash is only eight hexes long.  I’m used to it
> being 11 for this project?

It's not a fixed size. Long ago, the rule was "enough to be unique, but at least 7 (or whatever you set core.abbrev to)". These days that "7" is scaled based on the number of objects in the repo. See e6c587c733 (abbrev: auto size the default abbreviation, 2016-09-30).

So I'd expect 10 digits in a fresh clone of git.git. It's possible Junio has set core.abbrev to something fixed, though.

> Does the age of the commit matter?
Nope, it shouldn't.
-Peff
Previous: Kristoffer HaugsbakkNext: Kristoffer Haugsbakk
Message 9 of 22 in “forbid HEAD as a tagname”
  1. 0/4 forbid HEAD as a tagnameJunio C Hamano, Dec 2, 2024
  2. 1/4 refs: move ref name helpers aroundJunio C Hamano, Dec 2, 2024
  3. Jeff KingDec 2, 2024
  4. Junio C HamanoDec 3, 2024
  5. 2/4 refs: drop strbuf_ prefix from helpersJunio C Hamano, Dec 2, 2024
  6. Jeff KingDec 2, 2024
  7. 3/4 t5604: do not expect that HEAD is a valid tagnameJunio C Hamano, Dec 2, 2024
  8. Kristoffer HaugsbakkDec 2, 2024
  9. Jeff KingDec 2, 2024
  10. Kristoffer HaugsbakkDec 2, 2024
  11. Junio C HamanoDec 3, 2024
  12. Jeff KingDec 5, 2024
  13. Jeff KingDec 2, 2024
  14. 4/4 tag: "git tag" refuses to use HEAD as a tagnameJunio C Hamano, Dec 2, 2024
  15. Patrick SteinhardtDec 2, 2024
  16. shejialuoDec 2, 2024
  17. Junio C HamanoDec 3, 2024
  18. Jeff KingDec 5, 2024
  19. Jeff KingDec 5, 2024
  20. Rubén JustoDec 2, 2024
  21. Junio C HamanoDec 3, 2024
  22. Jeff KingDec 2, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.