Re: [PATCH 4/4] tag: "git tag" refuses to use HEAD as a tagname

From: shejialuo <shejialuo@gmail.com>
Date: Dec 2, 2024, 13:01 UTC
Message-ID: <Z02voaSNYRciv38z@ArchLinux>
In-Reply-To: <20241202070714.3028549-5-gitster@pobox.com>

On Mon, Dec 02, 2024 at 04:07:14PM +0900, Junio C Hamano wrote:

[snip]

Show 10 quoted lines

> diff --git a/refs.c b/refs.c
> index a24bfe3845..01ef2a3093 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -735,7 +735,7 @@ int check_branch_ref(struct strbuf *sb, const char *name)
>  
>  int check_tag_ref(struct strbuf *sb, const char *name)
>  {
> -	if (name[0] == '-')
> +	if (name[0] == '-' || !strcmp(name, "HEAD"))

I am wondering whether we should also update "check_refname_format" function to report "refs/heads/HEAD" and "refs/tags/HEAD" is bad ref name.

>  		return -1;
>  
>  	strbuf_reset(sb);

Thanks, Jialuo