Re: [PATCH 3/4] t5604: do not expect that HEAD is a valid tagname

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Dec 2, 2024, 21:09 UTC
Message-ID: <be4dccb2-70f1-4687-a052-caeb86e4e1c7@app.fastmail.com>
In-Reply-To: <20241202210006.GE776185@coredump.intra.peff.net>

On Mon, Dec 2, 2024, at 22:00, Jeff King wrote:

Show 12 quoted lines

> On Mon, Dec 02, 2024 at 01:19:56PM +0100, Kristoffer Haugsbakk wrote:
>
>> On Mon, Dec 2, 2024, at 08:07, Junio C Hamano wrote:
>> > 09116a1c (refs: loosen over-strict "format" check, 2011-11-16)
>>
>> Nit/confusion: the abbreviated hash is only eight hexes long.  I’m used to it
>> being 11 for this project?
>
> It's not a fixed size. Long ago, the rule was "enough to be unique, but
> at least 7 (or whatever you set core.abbrev to)". These days that "7" is
> scaled based on the number of objects in the repo. See e6c587c733
> (abbrev: auto size the default abbreviation, 2016-09-30).

Yes. 11 was based on the output I get as well as what seemed normal in the recent git log.

Show 7 quoted lines

>
> So I'd expect 10 digits in a fresh clone of git.git. It's possible Junio
> has set core.abbrev to something fixed, though.
>
>> Does the age of the commit matter?
>
> Nope, it shouldn't.

Makes sense.  Thanks.

-- 
Kristoffer Haugsbakk