From: Jeff King Date: Mon, 02 Dec 2024 21:00:06 GMT Subject: Re: [PATCH 3/4] t5604: do not expect that HEAD is a valid tagname Message-ID: <20241202210006.GE776185@coredump.intra.peff.net> In-Reply-To: <477f0dbd-60ed-4f73-b945-cdbdaf9f510a@app.fastmail.com> On Mon, Dec 02, 2024 at 01:19:56PM +0100, Kristoffer Haugsbakk wrote: > On Mon, Dec 2, 2024, at 08:07, Junio C Hamano wrote: > > 09116a1c (refs: loosen over-strict "format" check, 2011-11-16) > > Nit/confusion: the abbreviated hash is only eight hexes long. I’m used to it > being 11 for this project? It's not a fixed size. Long ago, the rule was "enough to be unique, but at least 7 (or whatever you set core.abbrev to)". These days that "7" is scaled based on the number of objects in the repo. See e6c587c733 (abbrev: auto size the default abbreviation, 2016-09-30). So I'd expect 10 digits in a fresh clone of git.git. It's possible Junio has set core.abbrev to something fixed, though. > Does the age of the commit matter? Nope, it shouldn't. -Peff