[PATCH 25/28] http-push: free xml_ctx.cdata after use
- From
Jeff King <peff@peff.net>
- Date
- Sep 24, 2024, 22:09 UTC
- Message-ID
- <20240924220954.GY1143820@coredump.intra.peff.net>
- In-Reply-To
- <20240924214930.GA1143523@coredump.intra.peff.net>
When we ask libexpat to parse XML data, we sometimes set xml_cdata as a CharacterDataHandler callback. This fills in an allocated string in the xml_ctx struct which we never free, causing a leak.
I won't pretend to understand the purpose of the field, but it looks like it is used by other callbacks during the parse. At any rate, we never look at it again after XML_Parse() returns, so we should be OK to free() it then.
This fixes several leaks triggered by t5540.
Signed-off-by: Jeff King <peff@peff.net> --- http-push.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/http-push.c b/http-push.c index 2e1c6851bb..1146d7c6fe 100644 --- a/http-push.c +++ b/http-push.c @@ -913,6 +913,7 @@ static struct remote_lock *lock_remote(const char *path, long timeout) result = XML_Parse(parser, in_buffer.buf, in_buffer.len, 1); free(ctx.name); + free(ctx.cdata); if (result != XML_STATUS_OK) { fprintf(stderr, "XML error: %s\n", XML_ErrorString( @@ -1170,6 +1171,7 @@ static void remote_ls(const char *path, int flags, result = XML_Parse(parser, in_buffer.buf, in_buffer.len, 1); free(ctx.name); + free(ctx.cdata); if (result != XML_STATUS_OK) { fprintf(stderr, "XML error: %s\n",
-- 2.46.2.1011.gf1f9323e02