[PATCH 11/28] fetch-pack: clear pack lockfiles list
- From
Jeff King <peff@peff.net>
- Date
- Sep 24, 2024, 21:58 UTC
- Message-ID
- <20240924215800.GK1143820@coredump.intra.peff.net>
- In-Reply-To
- <20240924214930.GA1143523@coredump.intra.peff.net>
If the --lock-pack option is passed (which it typically is when fetch-pack is used under the hood by smart-http), then we may end up with entries in our pack_lockfiles string_list. We need to clear them before returning to avoid a leak.
In git-fetch this isn't a problem, since the same cleanup happens via transport_unlock_pack(). But the leak is detectable in t5551, which does http fetches.
Signed-off-by: Jeff King <peff@peff.net> --- builtin/fetch-pack.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c index ef4143eef3..62e8c3aa6b 100644 --- a/builtin/fetch-pack.c +++ b/builtin/fetch-pack.c @@ -295,5 +295,6 @@ int cmd_fetch_pack(int argc, free_refs(remote_refs); list_objects_filter_release(&args.filter_options); oid_array_clear(&shallow); + string_list_clear(&pack_lockfiles, 0); return ret; }
-- 2.46.2.1011.gf1f9323e02