[PATCH 04/28] connect: clear child process before freeing in diagnostic mode

From: Jeff King <peff@peff.net>
Date: Sep 24, 2024, 21:51 UTC
Message-ID: <20240924215124.GD1143820@coredump.intra.peff.net>
In-Reply-To: <20240924214930.GA1143523@coredump.intra.peff.net>

The git_connect() function has a special CONNECT_DIAG_URL mode, where we stop short of actually connecting to the other side and just print some parsing details. For URLs that require a child process (like ssh), we free() the child_process struct but forget to clear it, leaking the strings we stuffed into its "env" list.

This leak is triggered many times in t5500, which uses "fetch-pack --diag-url", but we're not yet ready to mark it as leak-free.

Signed-off-by: Jeff King <peff@peff.net>
---
 connect.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/connect.c b/connect.c
index 6829ab3974..58f53d8dcb 100644
--- a/connect.c
+++ b/connect.c
@@ -1485,6 +1485,7 @@ struct child_process *git_connect(int fd[2], const char *url,
 
 				free(hostandport);
 				free(path);
+				child_process_clear(conn);
 				free(conn);
 				strbuf_release(&cmd);
 				return NULL;

-- 
2.46.2.1011.gf1f9323e02