[PATCH 17/28] remote-curl: free HEAD ref with free_one_ref()
- From
Jeff King <peff@peff.net>
- Date
- Sep 24, 2024, 22:03 UTC
- Message-ID
- <20240924220310.GQ1143820@coredump.intra.peff.net>
- In-Reply-To
- <20240924214930.GA1143523@coredump.intra.peff.net>
After dumb-http downloads the remote info/refs file, it adds an extra HEAD ref struct to our list by downloading the remote symref and finding the matching ref within our list. If either of those fails, we throw away the ref struct. But we do so with free(), when we should use free_one_ref() to catch any embedded allocations (in particular, if fetching the remote HEAD succeeded but the branch is unborn, its ref->symref field will be populated but we'll still throw it all away).
This leak is triggered by t5550 (but we still have a little more work to mark it leak-free).
Signed-off-by: Jeff King <peff@peff.net> --- remote-curl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/remote-curl.c b/remote-curl.c index 4adcf25ed6..9a71e04301 100644 --- a/remote-curl.c +++ b/remote-curl.c @@ -347,7 +347,7 @@ static struct ref *parse_info_refs(struct discovery *heads) ref->next = refs; refs = ref; } else { - free(ref); + free_one_ref(ref); } return refs;
-- 2.46.2.1011.gf1f9323e02