git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 08/15] reftable: ignore unused argc/argv in test functions

From
Jeff King <peff@peff.net>
Date
Aug 17, 2024, 08:23 UTC
Message-ID
<20240817082329.GH10287@coredump.intra.peff.net>
In-Reply-To
<20240817082101.GA6761@coredump.intra.peff.net>

There are several reftable test "main" functions that don't look at their argc/argv. They don't technically need to take these parameters, as they are called individually by cmd__reftable(). But it probably makes sense to keep them all consistent for now. In the long run these will probably all get converted to the unit-test framework anyway.

Signed-off-by: Jeff King <peff@peff.net>
---
 reftable/block_test.c     | 2 +-
 reftable/readwrite_test.c | 2 +-
 reftable/stack_test.c     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/reftable/block_test.c b/reftable/block_test.c
index 90aecd5a7c..f8e31d2d3c 100644
--- a/reftable/block_test.c
+++ b/reftable/block_test.c
@@ -116,7 +116,7 @@ static void test_block_read_write(void)
 	}
 }
 
-int block_test_main(int argc, const char *argv[])
+int block_test_main(int argc UNUSED, const char *argv[] UNUSED)
 {
 	RUN_TEST(test_block_read_write);
 	return 0;
diff --git a/reftable/readwrite_test.c b/reftable/readwrite_test.c
index f411abfe9c..15a113b78a 100644
--- a/reftable/readwrite_test.c
+++ b/reftable/readwrite_test.c
@@ -951,7 +951,7 @@ static void test_corrupt_table(void)
 	strbuf_release(&buf);
 }
 
-int readwrite_test_main(int argc, const char *argv[])
+int readwrite_test_main(int argc UNUSED, const char *argv[] UNUSED)
 {
 	RUN_TEST(test_log_zlib_corruption);
 	RUN_TEST(test_corrupt_table);
diff --git a/reftable/stack_test.c b/reftable/stack_test.c
index 8c36590ff0..f84b92f312 100644
--- a/reftable/stack_test.c
+++ b/reftable/stack_test.c
@@ -1084,7 +1084,7 @@ static void test_reftable_stack_compaction_concurrent_clean(void)
 	clear_dir(dir);
 }
 
-int stack_test_main(int argc, const char *argv[])
+int stack_test_main(int argc UNUSED, const char *argv[] UNUSED)
 {
 	RUN_TEST(test_empty_add);
 	RUN_TEST(test_read_file);
-- 
2.46.0.585.gd6679c16d8
Previous: Jeff KingNext: Jeff King
Message 9 of 18 in “marking some more unused parameters”
  1. 0/15 marking some more unused parametersJeff King, Aug 17, 2024
  2. 01/15 imap-send: mark unused parameter in ssl_socket_connect() fallbackJeff King, Aug 17, 2024
  3. 02/15 update-ref: mark more unused parameters in parser callbacksJeff King, Aug 17, 2024
  4. 03/15 refs: mark unused parameters in ref_store fsck callbacksJeff King, Aug 17, 2024
  5. 04/15 refs: mark unused parameters in do_for_each_reflog_helper()Jeff King, Aug 17, 2024
  6. 05/15 oss-fuzz: mark unused argv/argc argumentJeff King, Aug 17, 2024
  7. 06/15 t/helper: mark more unused argv/argc argumentsJeff King, Aug 17, 2024
  8. 07/15 unit-tests: ignore unused argc/argvJeff King, Aug 17, 2024
  9. 08/15 reftable: ignore unused argc/argv in test functionsJeff King, Aug 17, 2024
  10. 09/15 reftable: drop obsolete test function declarationsJeff King, Aug 17, 2024
  11. 10/15 reftable: mark unused parameters in virtual functionsJeff King, Aug 17, 2024
  12. 11/15 t-hashmap: mark unused parameters in callback functionJeff King, Aug 17, 2024
  13. Ghanshyam ThakkarAug 17, 2024
  14. Jeff KingAug 17, 2024
  15. 12/15 test-mergesort: mark unused parameters in trivial callbackJeff King, Aug 17, 2024
  16. 13/15 setup: mark unused parameter in config callbackJeff King, Aug 17, 2024
  17. 14/15 daemon: mark unused parameters in non-posix fallbacksJeff King, Aug 17, 2024
  18. 15/15 scalar: mark unused parameters in dummy functionJeff King, Aug 17, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.