git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/15] marking some more unused parameters

From
Jeff King <peff@peff.net>
Date
Aug 17, 2024, 08:21 UTC
Message-ID
<20240817082101.GA6761@coredump.intra.peff.net>

These are from my pile of -Wunused-parameter fixes. I built this on top of the "dropping" series I just posted at:

  https://lore.kernel.org/git/20240817072621.GA1535666@coredump.intra.peff.net/

but it should also be fine to apply it in parallel. This should hopefully be pretty quick to review, as it's only marking things UNUSED, and never removing them or changing code.

  [01/15]: imap-send: mark unused parameter in ssl_socket_connect() fallback
  [02/15]: update-ref: mark more unused parameters in parser callbacks
  [03/15]: refs: mark unused parameters in ref_store fsck callbacks
  [04/15]: refs: mark unused parameters in do_for_each_reflog_helper()
  [05/15]: oss-fuzz: mark unused argv/argc argument
  [06/15]: t/helper: mark more unused argv/argc arguments
  [07/15]: unit-tests: ignore unused argc/argv
  [08/15]: reftable: ignore unused argc/argv in test functions
  [09/15]: reftable: drop obsolete test function declarations
  [10/15]: reftable: mark unused parameters in virtual functions
  [11/15]: t-hashmap: mark unused parameters in callback function
  [12/15]: test-mergesort: mark unused parameters in trivial callback
  [13/15]: setup: mark unused parameter in config callback
  [14/15]: daemon: mark unused parameters in non-posix fallbacks
  [15/15]: scalar: mark unused parmaeters in dummy function
 builtin/update-ref.c             |  8 ++++----
 daemon.c                         |  6 +++---
 imap-send.c                      |  2 +-
 oss-fuzz/dummy-cmd-main.c        |  2 +-
 refs.c                           |  5 +++--
 refs/packed-backend.c            |  4 ++--
 refs/reftable-backend.c          | 18 +++++++++---------
 reftable/block_test.c            |  2 +-
 reftable/blocksource.c           |  8 ++++----
 reftable/generic.c               |  8 +++++---
 reftable/iter.c                  |  3 ++-
 reftable/readwrite_test.c        |  2 +-
 reftable/record.c                | 31 ++++++++++++++++++-------------
 reftable/reftable-tests.h        |  2 --
 reftable/stack_test.c            |  6 +++---
 reftable/test_framework.c        |  2 +-
 reftable/writer.c                |  2 +-
 scalar.c                         |  3 ++-
 setup.c                          |  2 +-
 t/helper/test-example-tap.c      |  2 +-
 t/helper/test-hashmap.c          |  2 +-
 t/helper/test-mergesort.c        |  2 +-
 t/unit-tests/t-ctype.c           |  2 +-
 t/unit-tests/t-hash.c            |  2 +-
 t/unit-tests/t-hashmap.c         |  3 ++-
 t/unit-tests/t-mem-pool.c        |  2 +-
 t/unit-tests/t-prio-queue.c      |  2 +-
 t/unit-tests/t-reftable-basics.c |  2 +-
 t/unit-tests/t-reftable-merged.c |  4 ++--
 t/unit-tests/t-reftable-pq.c     |  2 +-
 t/unit-tests/t-reftable-record.c |  2 +-
 t/unit-tests/t-reftable-tree.c   |  2 +-
 t/unit-tests/t-strbuf.c          |  2 +-
 t/unit-tests/t-strcmp-offset.c   |  2 +-
 t/unit-tests/t-strvec.c          |  2 +-
 t/unit-tests/t-trailer.c         |  2 +-
 36 files changed, 81 insertions(+), 72 deletions(-)
-Peff
Next: Jeff King
Message 1 of 18 in “marking some more unused parameters”
  1. 0/15 marking some more unused parametersJeff King, Aug 17, 2024
  2. 01/15 imap-send: mark unused parameter in ssl_socket_connect() fallbackJeff King, Aug 17, 2024
  3. 02/15 update-ref: mark more unused parameters in parser callbacksJeff King, Aug 17, 2024
  4. 03/15 refs: mark unused parameters in ref_store fsck callbacksJeff King, Aug 17, 2024
  5. 04/15 refs: mark unused parameters in do_for_each_reflog_helper()Jeff King, Aug 17, 2024
  6. 05/15 oss-fuzz: mark unused argv/argc argumentJeff King, Aug 17, 2024
  7. 06/15 t/helper: mark more unused argv/argc argumentsJeff King, Aug 17, 2024
  8. 07/15 unit-tests: ignore unused argc/argvJeff King, Aug 17, 2024
  9. 08/15 reftable: ignore unused argc/argv in test functionsJeff King, Aug 17, 2024
  10. 09/15 reftable: drop obsolete test function declarationsJeff King, Aug 17, 2024
  11. 10/15 reftable: mark unused parameters in virtual functionsJeff King, Aug 17, 2024
  12. 11/15 t-hashmap: mark unused parameters in callback functionJeff King, Aug 17, 2024
  13. Ghanshyam ThakkarAug 17, 2024
  14. Jeff KingAug 17, 2024
  15. 12/15 test-mergesort: mark unused parameters in trivial callbackJeff King, Aug 17, 2024
  16. 13/15 setup: mark unused parameter in config callbackJeff King, Aug 17, 2024
  17. 14/15 daemon: mark unused parameters in non-posix fallbacksJeff King, Aug 17, 2024
  18. 15/15 scalar: mark unused parameters in dummy functionJeff King, Aug 17, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.