git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 04/15] refs: mark unused parameters in do_for_each_reflog_helper()

From
Jeff King <peff@peff.net>
Date
Aug 17, 2024, 08:22 UTC
Message-ID
<20240817082222.GD10287@coredump.intra.peff.net>
In-Reply-To
<20240817082101.GA6761@coredump.intra.peff.net>

This is an each_ref_fn callback, so it has to match that interface. We marked most of these in 63e14ee2d6 (refs: mark unused each_ref_fn parameters, 2022-08-19), but in this case:

  - this function was created in 31f898397b (refs: drop unused params
    from the reflog iterator callback, 2024-02-21), and most of the
    arguments were correctly mark as UNUSED, but "flags" was missed.
  - commit e8207717f1 (refs: add referent to each_ref_fn, 2024-08-09)
    added a new argument to the each_ref_fn callback. In most callbacks
    it added an UNUSED annotation, but it missed one case.
Signed-off-by: Jeff King <peff@peff.net>
---
 refs.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/refs.c b/refs.c
index 74de3d3009..584674520e 100644
--- a/refs.c
+++ b/refs.c
@@ -2390,9 +2390,10 @@ struct do_for_each_reflog_help {
 	void *cb_data;
 };
 
-static int do_for_each_reflog_helper(const char *refname, const char *referent,
+static int do_for_each_reflog_helper(const char *refname,
+				     const char *referent UNUSED,
 				     const struct object_id *oid UNUSED,
-				     int flags,
+				     int flags UNUSED,
 				     void *cb_data)
 {
 	struct do_for_each_reflog_help *hp = cb_data;
-- 
2.46.0.585.gd6679c16d8
Previous: Jeff KingNext: Jeff King
Message 5 of 18 in “marking some more unused parameters”
  1. 0/15 marking some more unused parametersJeff King, Aug 17, 2024
  2. 01/15 imap-send: mark unused parameter in ssl_socket_connect() fallbackJeff King, Aug 17, 2024
  3. 02/15 update-ref: mark more unused parameters in parser callbacksJeff King, Aug 17, 2024
  4. 03/15 refs: mark unused parameters in ref_store fsck callbacksJeff King, Aug 17, 2024
  5. 04/15 refs: mark unused parameters in do_for_each_reflog_helper()Jeff King, Aug 17, 2024
  6. 05/15 oss-fuzz: mark unused argv/argc argumentJeff King, Aug 17, 2024
  7. 06/15 t/helper: mark more unused argv/argc argumentsJeff King, Aug 17, 2024
  8. 07/15 unit-tests: ignore unused argc/argvJeff King, Aug 17, 2024
  9. 08/15 reftable: ignore unused argc/argv in test functionsJeff King, Aug 17, 2024
  10. 09/15 reftable: drop obsolete test function declarationsJeff King, Aug 17, 2024
  11. 10/15 reftable: mark unused parameters in virtual functionsJeff King, Aug 17, 2024
  12. 11/15 t-hashmap: mark unused parameters in callback functionJeff King, Aug 17, 2024
  13. Ghanshyam ThakkarAug 17, 2024
  14. Jeff KingAug 17, 2024
  15. 12/15 test-mergesort: mark unused parameters in trivial callbackJeff King, Aug 17, 2024
  16. 13/15 setup: mark unused parameter in config callbackJeff King, Aug 17, 2024
  17. 14/15 daemon: mark unused parameters in non-posix fallbacksJeff King, Aug 17, 2024
  18. 15/15 scalar: mark unused parameters in dummy functionJeff King, Aug 17, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.