git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 01/15] imap-send: mark unused parameter in ssl_socket_connect() fallback

From
Jeff King <peff@peff.net>
Date
Aug 17, 2024, 08:21 UTC
Message-ID
<20240817082127.GA10287@coredump.intra.peff.net>
In-Reply-To
<20240817082101.GA6761@coredump.intra.peff.net>

Commit cea1ff7f1f (imap-send: drop global `imap_server_conf` variable, 2024-06-07) added an imap_server_conf parameter to several functions. But when compiled with NO_OPENSSL, the ssl_socket_connect() fallback just returns immediately, so its parameters all need to be annotated to avoid triggering -Wunused-parameter.

Signed-off-by: Jeff King <peff@peff.net>
---
 imap-send.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/imap-send.c b/imap-send.c
index 01404e5047..3551908de6 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -190,7 +190,7 @@ static void socket_perror(const char *func, struct imap_socket *sock, int ret)
 
 #ifdef NO_OPENSSL
 static int ssl_socket_connect(struct imap_socket *sock UNUSED,
-			      const struct imap_server_conf *cfg,
+			      const struct imap_server_conf *cfg UNUSED,
 			      int use_tls_only UNUSED)
 {
 	fprintf(stderr, "SSL requested but SSL support not compiled in\n");
-- 
2.46.0.585.gd6679c16d8
Previous: Jeff KingNext: Jeff King
Message 2 of 18 in “marking some more unused parameters”
  1. 0/15 marking some more unused parametersJeff King, Aug 17, 2024
  2. 01/15 imap-send: mark unused parameter in ssl_socket_connect() fallbackJeff King, Aug 17, 2024
  3. 02/15 update-ref: mark more unused parameters in parser callbacksJeff King, Aug 17, 2024
  4. 03/15 refs: mark unused parameters in ref_store fsck callbacksJeff King, Aug 17, 2024
  5. 04/15 refs: mark unused parameters in do_for_each_reflog_helper()Jeff King, Aug 17, 2024
  6. 05/15 oss-fuzz: mark unused argv/argc argumentJeff King, Aug 17, 2024
  7. 06/15 t/helper: mark more unused argv/argc argumentsJeff King, Aug 17, 2024
  8. 07/15 unit-tests: ignore unused argc/argvJeff King, Aug 17, 2024
  9. 08/15 reftable: ignore unused argc/argv in test functionsJeff King, Aug 17, 2024
  10. 09/15 reftable: drop obsolete test function declarationsJeff King, Aug 17, 2024
  11. 10/15 reftable: mark unused parameters in virtual functionsJeff King, Aug 17, 2024
  12. 11/15 t-hashmap: mark unused parameters in callback functionJeff King, Aug 17, 2024
  13. Ghanshyam ThakkarAug 17, 2024
  14. Jeff KingAug 17, 2024
  15. 12/15 test-mergesort: mark unused parameters in trivial callbackJeff King, Aug 17, 2024
  16. 13/15 setup: mark unused parameter in config callbackJeff King, Aug 17, 2024
  17. 14/15 daemon: mark unused parameters in non-posix fallbacksJeff King, Aug 17, 2024
  18. 15/15 scalar: mark unused parameters in dummy functionJeff King, Aug 17, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.