Re: [PATCH] t: avoid perl's pack/unpack "Q" specifier
- From
Jeff King <peff@peff.net>
- Date
- Nov 4, 2023, 04:59 UTC
- Message-ID
- <20231104045926.GA1492014@coredump.intra.peff.net>
- In-Reply-To
- <xmqq5y2ii91p.fsf@gitster.g>
On Sat, Nov 04, 2023 at 10:47:30AM +0900, Junio C Hamano wrote:
Show 8 quoted lines
> > +sub unpack_quad {
> > + my $bytes = shift;
> > + my ($n1, $n2) = unpack("NN", $bytes);
> > + die "quad value exceeds 32 bits" if $n1;
> > + return $n2;
> > +};
>
> Is this an unnecessary ';' at the end?Oops, yes. I'm not sure how that snuck in there. (It is not breaking anything, but if you were to remove it while applying, I would be very happy).
-Peff