git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [BUG] Git 2.43.0-rc0 - t4216 unpack(Q) invalid type

From
rsbecker@nexbridge.com <rsbecker@nexbridge.com>
Date
Nov 3, 2023, 19:18 UTC
Message-ID
<00a801da0e8a$97acc950$c7065bf0$@nexbridge.com>
In-Reply-To
<20231103162119.GC1470570@coredump.intra.peff.net>
On November 3, 2023 12:21 PM Jeff King wrote:
Show 24 quoted lines
>On Fri, Nov 03, 2023 at 12:07:17PM -0400, rsbecker@nexbridge.com wrote:
>
>> What I get from Perl is
>> $ perl -e '
>> >     my $bytes = "\1\2\3\4\5\6\7\8";
>> >     my $q = eval { unpack("Q>", $bytes) };
>> >     print "Q = ", defined($q) ? $q : "($@)", "\n";
>> >     my ($n1, $n2) = unpack("NN", $bytes);
>> >     print "n1 = $n1\n";
>> >     print "n2 = $n2\n";
>> >     print "computed quad = ", ($n1 << 32) | $n2, "\n";  '
>> Q = (Invalid type 'Q' in unpack at -e line 3.
>> )
>> n1 = 16909060
>> n2 = 84281144
>> computed quad = 84281144
>
>OK, that matches what I expected. Hopefully the patch I just sent (our mails just
>crossed) will fix it for you.
>
>> Because perl itself is 32-bit, not 64-bit on this platform. So even
>> moving git to 64-bit will not correct the issue.
>
>Yep, exactly.
Your patch worked! Thanks.
Previous: Jeff King
Message 10 of 10 in “[BUG] Git 2.43.0-rc0 - t4216 unpack(Q) invalid type”
  1. rsbecker@nexbridge.comNov 3, 2023
  2. rsbecker@nexbridge.comNov 3, 2023
  3. Jeff KingNov 3, 2023
  4. rsbecker@nexbridge.comNov 3, 2023
  5. t: avoid perl's pack/unpack "Q" specifierJeff King, Nov 3, 2023
  6. Junio C HamanoNov 4, 2023
  7. Jeff KingNov 4, 2023
  8. rsbecker@nexbridge.comNov 3, 2023
  9. Jeff KingNov 3, 2023
  10. rsbecker@nexbridge.comNov 3, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.