git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[BUG] Git 2.43.0-rc0 - t4216 unpack(Q) invalid type

From
rsbecker@nexbridge.com <rsbecker@nexbridge.com>
Date
Nov 3, 2023, 14:50 UTC
Message-ID
<007101da0e65$13e3c170$3bab4450$@nexbridge.com>

In RC0, the following tests are failing (with verbose). They look like the same root cause. Unpack("Q>".... What version does git now require for perl? I have v5.30.3 available, nothing more recent.

expecting success of 4216.141 'Bloom reader notices too-small data chunk': check_corrupt_graph BDAT clear 00000000 && echo "warning: ignoring too-small changed-path chunk" \ "(4 < 12) in commit-graph file" >expect.err && test_cmp expect.err err

Invalid type 'Q' in unpack at /home/jenkinsbuild/.jenkins/workspace/Git_Pipeline/t/lib-chunk/corrupt-chunk -file.pl line 31. not ok 141 - Bloom reader notices too-small data chunk # #check_corrupt_graph BDAT clear 00000000 && #echo "warning: ignoring too-small changed-path chunk" \ #"(4 < 12) in commit-graph file" >expect.err && #test_cmp expect.err err #

expecting success of 4216.142 'Bloom reader notices out-of-bounds filter offsets': check_corrupt_graph BIDX 12 FFFFFFFF && # use grep to avoid depending on exact chunk size grep "warning: ignoring out-of-range offset (4294967295) for changed-path filter at pos 3 of .git/objects/info/commit-graph" err

Invalid type 'Q' in unpack at /home/jenkinsbuild/.jenkins/workspace/Git_Pipeline/t/lib-chunk/corrupt-chunk -file.pl line 31. not ok 142 - Bloom reader notices out-of-bounds filter offsets # #check_corrupt_graph BIDX 12 FFFFFFFF && ## use grep to avoid depending on exact chunk size #grep "warning: ignoring out-of-range offset (4294967295) for changed-path filter at pos 3 of .git/objects/info/commit-graph" err #

expecting success of 4216.143 'Bloom reader notices too-small index chunk': # replace the index with a single entry, making most # lookups out-of-bounds check_corrupt_graph BIDX clear 00000000 && echo "warning: commit-graph changed-path index chunk" \ "is too small" >expect.err && test_cmp expect.err err

Invalid type 'Q' in unpack at /home/jenkinsbuild/.jenkins/workspace/Git_Pipeline/t/lib-chunk/corrupt-chunk -file.pl line 31. not ok 143 - Bloom reader notices too-small index chunk # ## replace the index with a single entry, making most ## lookups out-of-bounds #check_corrupt_graph BIDX clear 00000000 && #echo "warning: commit-graph changed-path index chunk" \ #"is too small" >expect.err && #test_cmp expect.err err #

expecting success of 4216.144 'Bloom reader notices out-of-order index offsets': # we do not know any real offsets, but we can pick # something plausible; we should not get to the point of # actually reading from the bogus offsets anyway. corrupt_graph BIDX 4 0000000c00000005 && echo "warning: ignoring decreasing changed-path index offsets" \ "(12 > 5) for positions 1 and 2 of .git/objects/info/commit-graph"

>expect.err &&

git -c core.commitGraph=false log -- A/B/file2 >expect.out && git -c core.commitGraph=true log -- A/B/file2 >out 2>err && test_cmp expect.out out && test_cmp expect.err err

Invalid type 'Q' in unpack at /home/jenkinsbuild/.jenkins/workspace/Git_Pipeline/t/lib-chunk/corrupt-chunk -file.pl line 31. not ok 144 - Bloom reader notices out-of-order index offsets # ## we do not know any real offsets, but we can pick ## something plausible; we should not get to the point of ## actually reading from the bogus offsets anyway. #corrupt_graph BIDX 4 0000000c00000005 && #echo "warning: ignoring decreasing changed-path index offsets" \ #"(12 > 5) for positions 1 and 2 of .git/objects/info/commit-graph"

>expect.err &&

#git -c core.commitGraph=false log -- A/B/file2 >expect.out && #git -c core.commitGraph=true log -- A/B/file2 >out 2>err && #test_cmp expect.out out && #test_cmp expect.err err #

-- Brief whoami: NonStop&UNIX developer since approximately UNIX(421664400) NonStop(211288444200000000) -- In real life, I talk too much.

Next: rsbecker@nexbridge.com
Message 1 of 10 in “[BUG] Git 2.43.0-rc0 - t4216 unpack(Q) invalid type”
  1. rsbecker@nexbridge.comNov 3, 2023
  2. rsbecker@nexbridge.comNov 3, 2023
  3. Jeff KingNov 3, 2023
  4. rsbecker@nexbridge.comNov 3, 2023
  5. t: avoid perl's pack/unpack "Q" specifierJeff King, Nov 3, 2023
  6. Junio C HamanoNov 4, 2023
  7. Jeff KingNov 4, 2023
  8. rsbecker@nexbridge.comNov 3, 2023
  9. Jeff KingNov 3, 2023
  10. rsbecker@nexbridge.comNov 3, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.