Re: [BUG] Git 2.43.0-rc0 - t4216 unpack(Q) invalid type

From: Jeff King <peff@peff.net>
Date: Nov 3, 2023, 16:21 UTC
Message-ID: <20231103162119.GC1470570@coredump.intra.peff.net>
In-Reply-To: <007f01da0e6f$d5031a40$7f094ec0$@nexbridge.com>

On Fri, Nov 03, 2023 at 12:07:17PM -0400, rsbecker@nexbridge.com wrote:

Show 14 quoted lines

> What I get from Perl is 
> $ perl -e '
> >     my $bytes = "\1\2\3\4\5\6\7\8";
> >     my $q = eval { unpack("Q>", $bytes) };
> >     print "Q = ", defined($q) ? $q : "($@)", "\n";
> >     my ($n1, $n2) = unpack("NN", $bytes);
> >     print "n1 = $n1\n";
> >     print "n2 = $n2\n";
> >     print "computed quad = ", ($n1 << 32) | $n2, "\n";  '
> Q = (Invalid type 'Q' in unpack at -e line 3.
> )
> n1 = 16909060
> n2 = 84281144
> computed quad = 84281144

OK, that matches what I expected. Hopefully the patch I just sent (our mails just crossed) will fix it for you.

> Because perl itself is 32-bit, not 64-bit on this platform. So even
> moving git to 64-bit will not correct the issue.

Yep, exactly.

-Peff