Re: [PATCH v7 7/7] tr2: dump names if config exist in multiple scopes

From: tenglong.tl <dyroneteng@gmail.com>
Date: Jul 20, 2022, 12:48 UTC
Message-ID: <20220720124847.65619-1-tenglong.tl@tenglongtldeMacBook-Pro.local>
In-Reply-To: <xmqq4jzcak8g.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> This make it sound as if we do not show the scope if a configuration
> variable appears only in one scope, but I do not see how the updated
> code achieves that.  Instead, it seems that it shows the scope
> unconditionally in addition to the key-value pair.

Yes. There is a problem with this statement. I will fix it, maybe like:

  tr2: print corresponding scope with config key-value

> If that is the case, a retitle is in order.  Also this should
> probably be a separate topic, unrelated from the other 6 patches.

That's the case. I will send the [0-6] as the v8, and separate [7/7] as a new patch series.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.