Re: [PATCH v2 3/5] pack-bitmap.c: make warnings more detailed when opening bitmap

From: Teng Long <dyroneteng@gmail.com>
Date: May 6, 2022, 09:08 UTC
Message-ID: <20220506090833.17033-1-dyroneteng@gmail.com>
In-Reply-To: <YmGTphnsVJn7CX5V@nand.local>

On Thu, 21 Apr 2022 13:25:58 -0400, Taylor Blau wrote:

> I'm glad that the existing warning has been marked for translation.
> There's no reason that it couldn't have been before, so I'm glad to see
> it added now.

Thanks and it's actually suggested by Ævar Arnfjörð Bjarmason.

Show 8 quoted lines

> But I'm not sure that the new warning tells the user anything that the
> old one didn't. The old warning says "ignoring extra bitmap file: ...",
> leading us to believe that another one has already been opened. The new
> warning makes the latter part explicit, but I don't think it adds any
> new information that wasn't already readily available.
> ... 
> This is out of sync with the warning you added, causing t5310.74 to
> fail.

Yeah, I agree with you about this. Will roll back on here and fix the broken test in next patch.

Thanks