Re: [PATCH v3 4/5] pack-bitmap.c: using error() instead of silently returning -1

From: Teng Long <dyroneteng@gmail.com>
Date: Jun 20, 2022, 13:17 UTC
Message-ID: <20220620131730.23409-1-dyroneteng@gmail.com>
In-Reply-To: <YqfhR/PV6HhGyhT5@nand.local>

On Mon, 13 Jun 2022 21:15:51 -0400, Taylor Blau wrote:

> Since we are handling an error from fstat here, the errno variable
> contains useful information that we should include in the error via
> error_errno().

Appreciate for reminding this. Will fix.

> The other error strings are marked for translation, but this one is not.
> Was that intentional, or just a typo / oversight?

It's an oversight. Will fix.

> Same note here about using error_errno() instead of just error().

As same as the first one, will fix.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.