git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-completion.bash: stash-show: add --patch-with-stat

From
Denton Liu <liu.denton@gmail.com>
Date
Sep 29, 2020, 06:25 UTC
Message-ID
<20200929062555.GA45164@generichostname>
In-Reply-To
<xmqqh7rhn3nk.fsf@gitster.c.googlers.com>
Hi Junio,
On Mon, Sep 28, 2020 at 11:43:11AM -0700, Junio C Hamano wrote:
> In any case, it might make more sense to do this instead, and then
> rethink what options make sense to these subcommands of "git stash".
> I do not think patch-with-stat should be among them.

Perhaps it would make sense to add --patch and --no-patch to $__git_diff_common_options and then use that list for `git stash show` since it's documented that all of the diff options are valid.

Thanks, Denton

Previous: Junio C HamanoNext: Robert Karszniewicz
Message 3 of 6 in “git-completion.bash: stash-show: add --patch-with-stat”
  1. git-completion.bash: stash-show: add --patch-with-statRobert Karszniewicz, Sep 28, 2020
  2. Junio C HamanoSep 28, 2020
  3. Denton LiuSep 29, 2020
  4. Robert KarszniewiczSep 29, 2020
  5. Junio C HamanoSep 30, 2020
  6. Robert KarszniewiczSep 30, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.