From: Denton Liu <liu.denton@gmail.com>
Date: Tue, 29 Sep 2020 06:25:55 GMT
Subject: Re: [PATCH] git-completion.bash: stash-show: add --patch-with-stat
Message-ID: <20200929062555.GA45164@generichostname>
In-Reply-To: <xmqqh7rhn3nk.fsf@gitster.c.googlers.com>

Hi Junio,

On Mon, Sep 28, 2020 at 11:43:11AM -0700, Junio C Hamano wrote:
> In any case, it might make more sense to do this instead, and then
> rethink what options make sense to these subcommands of "git stash".
> I do not think patch-with-stat should be among them.

Perhaps it would make sense to add --patch and --no-patch to
$__git_diff_common_options and then use that list for `git stash show`
since it's documented that all of the diff options are valid.

Thanks,
Denton