Re: [PATCH] git-completion.bash: stash-show: add --patch-with-stat
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 28, 2020, 18:43 UTC
- Message-ID
- <xmqqh7rhn3nk.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20200928110517.24915-1-avoidr@posteo.de>
Robert Karszniewicz <avoidr@posteo.de> writes:
Show 17 quoted lines
> Signed-off-by: Robert Karszniewicz <avoidr@posteo.de> > --- > contrib/completion/git-completion.bash | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > index 8be4a0316e..d98c731667 100644 > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -3016,7 +3016,10 @@ _git_stash () > list,--*) > __gitcomp "--name-status --oneline --patch-with-stat" > ;; > - show,--*|branch,--*) > + show,--*) > + __gitcomp "--patch-with-stat" > + ;;
Why is --patch-with-stat so special?
Without completion support for "--patch" and "--stat", typing "--<TAB>" after "git stash show" and seeing only "--patch-with-stat" (which has been made obsolete-but-still-kept synonym immediately after the other two were invented in 2005) would make a rather surprising experience to the end users. For "show" alone, it may make a lot of sense to complete "git stash show -<TAB>" and offer "-p".
In any case, it might make more sense to do this instead, and then rethink what options make sense to these subcommands of "git stash". I do not think patch-with-stat should be among them.
- list,--*) + list,--* | show,--*) __gitcomp "--name-status --oneline --patch-with-stat"
Thanks.