Re: [PATCH] git-completion.bash: stash-show: add --patch-with-stat

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 30, 2020, 19:09 UTC
Message-ID: <xmqqo8lngjze.fsf@gitster.c.googlers.com>
In-Reply-To: <20200929213154.GA18321@HP>

Robert Karszniewicz <avoidr@posteo.de> writes:

Show 6 quoted lines

>> surprising experience to the end users.  For "show" alone, it may
>> make a lot of sense to complete "git stash show -<TAB>" and offer
>> "-p".
>
> Does git complete short options at all? I only see long options
> completed. (I'm also very new to bash-completion)

I wouldn't personally recommend it, but I did see a patch that added support for one short option completion quite recently. As long as "--<TAB>" gets completed to often-used options, among which "--patch" and "--stat" are included, it would be OK not to react to "-<TAB>".

Show 6 quoted lines

>> In any case, it might make more sense to do this instead, and then
>> rethink what options make sense to these subcommands of "git stash".
>> I do not think patch-with-stat should be among them.
>
> So shall I do a v2 as per your suggestion and replace
> "--patch-with-stat" with "--patch --stat"?

I think Denton Liu offered a different suggestion; I didn't look at and compare which direction is the better one myself, but an approach that keeps the number of manually-maintained list of options low is almost always a good approach.

Thanks.