git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 0/3] upload-pack: custom allowed object filters

From
Jeff King <peff@peff.net>
Date
Aug 4, 2020, 00:37 UTC
Message-ID
<20200804003722.GA2726931@coredump.intra.peff.net>
In-Reply-To
<cover.1596476928.git.me@ttaylorr.com>
On Mon, Aug 03, 2020 at 02:00:04PM -0400, Taylor Blau wrote:
> Here's what I anticipate to be the final reroll of my series to teach
> the new 'uploadpackfilter' configuration section, which allows for more
> fine-grained control over which object filters upload-pack is willing to
> serve.
Thanks, this version looks good to me.
> Two changes from last time:
> 
>   - I adopted Peff's suggestion in beginning in [1], but appropriately
>     split it over the existing patch structure.

The adaptation looks good. The send_err_and_die() helper could possibly be used for some of the packet_writer_error() callers, too. Somebody could convert them on top if they want, but I'm not sure it's even worth it. IMHO the correct long-term direction is to convert those die() calls into silent exits and let the ERR packet speak for itself. But we shouldn't do that until the client side is more robust against pipe-death races.

>   - I dropped the old patch 3/4, since it really should have never been
>     there in the first place, and just made the refactoring more noisy
>     than necessary.

Yeah, I think folding it in to the first patch as you did makes the series simpler to follow.

-Peff
Previous: Taylor Blau
Message 32 of 32 in “upload-pack: custom allowed object filters”
  1. 0/4 upload-pack: custom allowed object filtersTaylor Blau, Jul 23, 2020
  2. 1/4 list_objects_filter_options: introduce 'list_object_filter_config_name'Taylor Blau, Jul 23, 2020
  3. 2/4 upload-pack.c: allow banning certain object filter(s)Taylor Blau, Jul 23, 2020
  4. 3/4 upload-pack.c: pass 'struct list_objects_filter_options *'Taylor Blau, Jul 23, 2020
  5. 4/4 upload-pack.c: introduce 'uploadpackfilter.tree.maxDepth'Taylor Blau, Jul 23, 2020
  6. SZEDER GáborJul 23, 2020
  7. Taylor BlauJul 24, 2020
  8. Jeff KingJul 24, 2020
  9. Taylor BlauJul 27, 2020
  10. SZEDER GáborJul 27, 2020
  11. Taylor BlauJul 27, 2020
  12. Jeff KingJul 27, 2020
  13. SZEDER GáborJul 27, 2020
  14. Taylor BlauJul 27, 2020
  15. 0/4 upload-pack: custom allowed object filtersTaylor Blau, Jul 31, 2020
  16. 1/4 list_objects_filter_options: introduce 'list_object_filter_config_name'Taylor Blau, Jul 31, 2020
  17. 2/4 upload-pack.c: allow banning certain object filter(s)Taylor Blau, Jul 31, 2020
  18. Jeff KingJul 31, 2020
  19. Taylor BlauJul 31, 2020
  20. 3/4 upload-pack.c: pass 'struct list_objects_filter_options *'Taylor Blau, Jul 31, 2020
  21. 4/4 upload-pack.c: introduce 'uploadpackfilter.tree.maxDepth'Taylor Blau, Jul 31, 2020
  22. Jeff KingJul 31, 2020
  23. Jeff KingJul 31, 2020
  24. Taylor BlauJul 31, 2020
  25. Taylor BlauJul 31, 2020
  26. Jeff KingJul 31, 2020
  27. Jeff KingJul 31, 2020
  28. 0/3 upload-pack: custom allowed object filtersTaylor Blau, Aug 3, 2020
  29. 2/3 upload-pack.c: allow banning certain object filter(s)Taylor Blau, Aug 3, 2020
  30. 1/3 list_objects_filter_options: introduce 'list_object_filter_config_name'Taylor Blau, Aug 3, 2020
  31. 3/3 upload-pack.c: introduce 'uploadpackfilter.tree.maxDepth'Taylor Blau, Aug 3, 2020
  32. Jeff KingAug 4, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.