Re: [PATCH v2 0/4] upload-pack: custom allowed object filters

From: Jeff King <peff@peff.net>
Date: Jul 24, 2020, 19:51 UTC
Message-ID: <20200724195126.GB4013174@coredump.intra.peff.net>
In-Reply-To: <20200724165133.GA15287@syl.lan>

On Fri, Jul 24, 2020 at 12:51:33PM -0400, Taylor Blau wrote:

Show 13 quoted lines

> Let me double check my understanding... I think that you are suggesting
> the following three things:
> 
>   - Write the same message as an err packet over the wire as we do when
>     'die()'ing from inside of upload-pack.c
> 
>   - Don't mark said message(s) for translation, matching what we do in
>     the rest of upload-pack.c.
> 
>   - Re-introduce the 'test_must_fail ok=sigpipe' and stop grepping
>     stderr for the right message.
> 
> Do I have that right?

I'm not Gábor, but that is the sequence I think is best.

Between the die() and the ERR, the ERR packets are way more useful in practice, since they actually go back to the client. I'd even suggest we do away with the die() messages entirely (since they're either redundant or go nowhere, depending on the protocol), but I think it would make sense to wait until the raciness issues are fixed (until then, they _might_ help in the redundant cases, which is what the test here is relying on).

-Peff