Re: [PATCH v2 0/4] upload-pack: custom allowed object filters
- From
Jeff King <peff@peff.net>
- Date
- Jul 27, 2020, 19:42 UTC
- Message-ID
- <20200727194215.GB795313@coredump.intra.peff.net>
- In-Reply-To
- <20200727193657.GC62919@syl.lan>
On Mon, Jul 27, 2020 at 03:36:57PM -0400, Taylor Blau wrote:
Show 9 quoted lines
> > > and stop grepping stderr for the right message. > > > > No, please check them, I love those error messages :) > > Isn't the problem that these messages only sometimes make it to the > client depending on what protocol is in use? If so, the right thing to > do would be to not grep for them, since it will make that test flakey. > > Maybe I'm misunderstanding you/the problem...
You'd have to omit them for tests over certain protocols, but it would always be robust to check them over local-filesystem clones and fetches. So it may be that some tests need them and some do not.
-Peff