Re: [PATCH v2 0/4] upload-pack: custom allowed object filters

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Jul 23, 2020, 20:43 UTC
Message-ID: <20200723204325.GM11341@szeder.dev>
In-Reply-To: <cover.1595468657.git.me@ttaylorr.com>

On Wed, Jul 22, 2020 at 09:48:54PM -0400, Taylor Blau wrote:

Show 10 quoted lines

> Here's a much-delayed v2 of my series to teach upload-pack to limit the
> kinds of object filters that it is willing to server in a request.
> 
> Much is the same since last time, with two notable exceptions:
> 
>   - We use the 'uploadpackfilter' top-level configuration key instead of
>     pretending that 'uploadpack.filter' is top-level, which greatly
>     simplifies the call to 'parse_config_key()'.
> 
>   - Instead of writing an err packet, 'git upload-pack' simply 'die()'s,

To clarify, I only recommended to pass the same message to die() as in the ERR packet, not dropping the ERR packet, because ...

>     which propagates the error through 'git clone' always,

it does in the new tests when creating a local clone, but does it really work with all protocols and remote helpers and what not?

>     and resolves
>     a flaky set of tests that used to result in a SIGPIPE.

This doesn't resolve the SIGPIPE flakiness, because 'git upload-pack' can still abort while 'git clone' is still sending packets. IOW we still need that 'test_must_fail ok=sigpipe' in all new tests.